Skip to content

Commit

Permalink
Add type to OrderedDict
Browse files Browse the repository at this point in the history
OrderedDict needs to be typed just like Dict needs to be typed.  The
OrderedDict "input" variable key and value are used to append to a
string without any processing, so it seems unlikely that something other
than a string would be valid.
  • Loading branch information
nakato committed May 17, 2021
1 parent d1644e3 commit fa28310
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions github/Requester.pyi
Expand Up @@ -158,7 +158,7 @@ class Requester:
url: str,
parameters: Optional[Dict[str, Any]] = ...,
headers: Optional[Dict[str, Any]] = ...,
input: Optional[OrderedDict] = ...,
input: Optional[OrderedDict[str, str]] = ...,
cnx: Optional[
Union[HTTPRequestsConnectionClass, HTTPSRequestsConnectionClass]
] = ...,
Expand All @@ -169,7 +169,7 @@ class Requester:
url: str,
parameters: Optional[Dict[str, Any]] = ...,
headers: Optional[Dict[str, Any]] = ...,
input: Optional[OrderedDict] = ...,
input: Optional[OrderedDict[str, str]] = ...,
) -> Tuple[Dict[str, Any], Optional[Dict[str, Any]]]: ...
@classmethod
def resetConnectionClasses(cls) -> None: ...
Expand Down

0 comments on commit fa28310

Please sign in to comment.