Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a way to delete a PR review? #1856

Closed
jesusvasquez333 opened this issue Feb 18, 2021 · 2 comments · Fixed by #1897
Closed

Is there a way to delete a PR review? #1856

jesusvasquez333 opened this issue Feb 18, 2021 · 2 comments · Fixed by #1897
Labels
feature request

Comments

@jesusvasquez333
Copy link

Hello all,

Is there a way to delete a PR review created with create_review?

It seems like the GitHub API supports it, but I don't find that method in the code or documentation.

Thanks!
@johnsc1
Copy link
Contributor

johnsc1 commented Mar 12, 2021

Hello,
A group of student developers I am part of are interested in this issue and would like to try and implement a new function that uses the Github API method mentioned above to try and resolve this issue. Here is the fork where we will be working.

@sameer1996-cmd
Copy link

Hello, I would like to try and resolve this issue.

@johnsc1 johnsc1 mentioned this issue Mar 26, 2021
Merged
s-t-e-v-e-n-k pushed a commit that referenced this issue Oct 24, 2021
@johnsc1 @bagashvilit @WonjoonC
Add function to delete pending reviews on a pull request (#1897)
c8a945b 
Add a delete method to PullRequestReview to allow dismissing them.

Fixes #1856 

Co-authored-by: bagashvilit <bagashvilit@allegheny.edu>
Co-authored-by: WonjoonC <chos@allegheny.edu>
simkimsia added a commit to simkimsia/PyGithub that referenced this issue Oct 24, 2021
@simkimsia
Squashed commit of the following:
891f450 
commit 6452ddf
Author: Steve Kowalik <steven@wedontsleep.org>
Date:   Sun Oct 24 15:21:31 2021 +1100

    Add Repository.rename_branch method (PyGithub#2089)

    The GitHub API exposes an endpoint to rename a branch, so we should
    support calling it. Sadly, there is not enough information to add
    that method to the Branch class, so expose it in the Repository object.

    Fixes PyGithub#1901

commit c8a945b
Author: Claire Johns <42869556+johnsc1@users.noreply.github.com>
Date:   Sun Oct 24 00:15:31 2021 -0400

    Add function to delete pending reviews on a pull request (PyGithub#1897)

    Add a delete method to PullRequestReview to allow dismissing them.

    Fixes PyGithub#1856

    Co-authored-by: bagashvilit <bagashvilit@allegheny.edu>
    Co-authored-by: WonjoonC <chos@allegheny.edu>

commit f1faf94
Author: Steve Kowalik <steven@wedontsleep.org>
Date:   Fri Oct 22 08:39:31 2021 +1100

    Cover all code paths in search_commits (PyGithub#2087)

    The search_commits method was only very lightly tested, meaning over
    half of it was not covered. Write another test case, covering all code
    paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add function to delete pending reviews on a pull request CS481-Team-Pumpkin/PyGithub
4 participants
@jesusvasquez333 @s-t-e-v-e-n-k @johnsc1 @sameer1996-cmd