Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test issue to be created #866

Closed
sfdye opened this issue Aug 16, 2018 · 0 comments
Closed

test issue to be created #866

sfdye opened this issue Aug 16, 2018 · 0 comments
Projects
simple-kanban

Comments

@sfdye
Copy link
Member

sfdye commented Aug 16, 2018

No description provided.

@sfdye sfdye created this issue from a note in simple-kanban (To do) Aug 16, 2018
@sfdye sfdye closed this as completed Aug 16, 2018
@allevin allevin mentioned this issue Aug 16, 2018
Merged
27 tasks
sfdye pushed a commit that referenced this issue Aug 24, 2018
@allevin @sfdye
Adding new attributes to IssueEvent (#857)
7ac2a2a 
See Issue #855 

The class [IssueEvent](https://github.com/PyGithub/PyGithub/blob/master/github/IssueEvent.py) is missing a large number of attributes documented in the [API](https://developer.github.com/v3/issues/events/).

This is also commented about in #653 to a degree

27 of the tests 27 known event types have tests.

**Currently Tested using Issue #30**            
- [x] subscribed
- [x] assigned
- [x] referenced               
- [x] closed                   
- [x] labeled                  

**Currently Tested using Issue/PR #538**
- [x] merged
- [x] mentioned
- [x] review_requested

**Currently Tested using Issue/PR #857**
- [x] reopened
- [x] unassigned
- [x] unlabeled
- [x] renamed
- [x] base_ref_changed
- [x] head_ref_deleted 
- [x] head_ref_restored
- [x] milestoned
- [x] demilestoned
- [x] locked
- [x] unlocked
- [x] review_dismissed
- [x] review_request_removed
- [x] marked_as_duplicate
- [x] unmarked_as_duplicate
- [x] added_to_project       
- [x] moved_columns_in_project
- [x] removed_from_project
- [x] converted_note_to_issue - Note: this event is tied into Issue #866 

This PR is now ready to be merged
candrikos pushed a commit to candrikos/PyGithub that referenced this issue Sep 25, 2020
@allevin @candrikos
Adding new attributes to IssueEvent (PyGithub#857)
5b482b6 
See Issue PyGithub#855 

The class [IssueEvent](https://github.com/PyGithub/PyGithub/blob/master/github/IssueEvent.py) is missing a large number of attributes documented in the [API](https://developer.github.com/v3/issues/events/).

This is also commented about in PyGithub#653 to a degree

27 of the tests 27 known event types have tests.

**Currently Tested using Issue PyGithub#30**            
- [x] subscribed
- [x] assigned
- [x] referenced               
- [x] closed                   
- [x] labeled                  

**Currently Tested using Issue/PR PyGithub#538**
- [x] merged
- [x] mentioned
- [x] review_requested

**Currently Tested using Issue/PR PyGithub#857**
- [x] reopened
- [x] unassigned
- [x] unlabeled
- [x] renamed
- [x] base_ref_changed
- [x] head_ref_deleted 
- [x] head_ref_restored
- [x] milestoned
- [x] demilestoned
- [x] locked
- [x] unlocked
- [x] review_dismissed
- [x] review_request_removed
- [x] marked_as_duplicate
- [x] unmarked_as_duplicate
- [x] added_to_project       
- [x] moved_columns_in_project
- [x] removed_from_project
- [x] converted_note_to_issue - Note: this event is tied into Issue PyGithub#866 

This PR is now ready to be merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
simple-kanban
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfdye