Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GithubIntegration: enable getting installation #1135

Merged
merged 1 commit into from Jun 20, 2019

Conversation

TomasTomecek
Copy link
Contributor

@TomasTomecek TomasTomecek commented Jun 9, 2019

I tried adding this to the Repository class but since the request requires jwt token and the special headers, it was too much of a hassle.

I need a bit of help with adding replay tests. Figured it out, ready for review.

Related #725 #828 #1021

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek
Copy link
Contributor Author

can this be merged?

@sfdye sfdye merged commit 1818704 into PyGithub:master Jun 20, 2019
@TomasTomecek TomasTomecek deleted the get-inst-id-for-repo branch June 20, 2019 09:27
@ericofusco
Copy link

@TomasTomecek Installation can be done for organizations too. https://developer.github.com/v3/apps/#get-an-organization-installation
Does it make sense to have a new method to do this or use the org URI if repo is not given?

@TomasTomecek
Copy link
Contributor Author

@ericofusco the code in this PR should be able to handle both

@ericofusco
Copy link

@TomasTomecek Maybe I missing something, new method only calls /repos endpoint. Accordingly to github docs to get an installation for an organization the URI is under /orgs path. Method from PR only gets an installation for a single repo, not for an organization (to manage members and teams for example).

@TomasTomecek
Copy link
Contributor Author

@ericofusco oh, I misunderstood your previous comment. You/re right then.

@atodorov
Copy link

@TomasTomecek I am looking into the original comment in #725 where from the integration I want to get an installation via its specific ID and for that installation get all the repositories it can access. This PR seems to be different so can you explain a bit?

I can work on adding what I need and send a PR but I need some context of what & how was done previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants