add GithubObject.last_modified_at datetime

[casperdcl]

No description provided.

[codecov-io]

Codecov Report

Merging #1270 into master will decrease coverage by 0.61%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   98.34%   97.73%   -0.62%     
==========================================
  Files         188      184       -4     
  Lines       14083    12961    -1122     
==========================================
- Hits        13850    12667    -1183     
- Misses        233      294      +61

Impacted Files	Coverage Δ
github/GithubObject.py	97.98% <50%> (-1.42%)	⬇️
github/Membership.py	26.19% <0%> (-73.81%)	⬇️
github/Topic.py	77.41% <0%> (-22.59%)	⬇️
github/Invitation.py	83.63% <0%> (-16.37%)	⬇️
github/Rate.py	95.45% <0%> (-4.55%)	⬇️
github/ProjectCard.py	97.01% <0%> (-1.83%)	⬇️
github/Plan.py	96.29% <0%> (-1.33%)	⬇️
github/License.py	90.41% <0%> (-1.16%)	⬇️
github/Repository.py	96.3% <0%> (-0.98%)	⬇️
github/InstallationAuthorization.py	87.5% <0%> (-0.97%)	⬇️
... and 179 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2991e9f...1aa5834. Read the comment docs.

[TravisBuddy]

Hey @casperdcl,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 96f99ae0-f59a-11e9-a1fe-396a3052531f

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[casperdcl]

@s-t-e-v-e-n-k I think this is mergable as-is.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sfdye]

@casperdcl From my end I see that there is a merge conflict for:
github/GithubObject.py

Could you help to resolve this first?

[casperdcl]

@sfdye rebased now

[sfdye]

@casperdcl Unfortunately the black CI stage failed, please see:
https://github.com/PyGithub/PyGithub/blob/master/CONTRIBUTING.md#coding-style
on how to fix it

[brymon68]

Any updates on this?

[sfdye]

Oh I just realized the last_modified is from the response header. Thank you very much for your contribution but PyGithub won't implement anything that's not from the official API. (in this case last_modified_at). Feel free to implement this in your own application.

[casperdcl]

@sfdye I'm not sure I follow; are you saying that last_modified should never have been implemented? Or are you only talking about this PR which adds last_modified_at?

[sfdye]

I am talking about the _at

[casperdcl]

Ok, it just seemed consistent since PyGithub exposes created_at and updated_at, making use of _makeDatetimeAttribute.