Add delete_branch_on_merge arg to Repository.edit type stub #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### example
```python3
from github import Github
Github().get_repo("").edit(
has_issues=False,
has_projects=False,
has_wiki=False,
default_branch="master",
allow_squash_merge=False,
allow_merge_commit=True,
allow_rebase_merge=False,
delete_branch_on_merge=False,
)
```
#### before changes
```console
% mypy example.py
example.py:3: error: Unexpected keyword argument
"delete_branch_on_merge" for "edit" of "Repository"
github/Repository.pyi:219: note: "edit" of "Repository" defined here
Found 1 error in 1 file (checked 1 source file)
```
#### after changes
```console
% mypy example.py
Success: no issues found in 1 source file
```
Codecov Report
@@ Coverage Diff @@
## master #1639 +/- ##
==========================================
+ Coverage 98.52% 98.66% +0.14%
==========================================
Files 48 48
Lines 2304 2555 +251
==========================================
+ Hits 2270 2521 +251
Misses 34 34
Continue to review full report at Codecov.
|
dallinbryce
approved these changes
Aug 4, 2020
s-t-e-v-e-n-k
approved these changes
Aug 5, 2020
|
I think this is needed in Organization.create_repo too? |
dato
added a commit
to dato/algo2_sistema_entregas
that referenced
this pull request
Oct 2, 2020
Also:
- actualizar PyGithub de 1.51 a 1.53 para los typing hints de
delete_branch_on_merge (PyGithub/PyGithub#1639, incompleta)
- eliminar ramas de except KeyError/ValueError que ya no aplican
tras el último refactor a alu_repos.py
dato
added a commit
to algoritmos-rw/algo2_sistema_entregas
that referenced
this pull request
Oct 2, 2020
) Also: - actualizar PyGithub de 1.51 a 1.53 para los typing hints de delete_branch_on_merge (PyGithub/PyGithub#1639, incompleta) - eliminar ramas de except KeyError/ValueError que ya no aplican tras el último refactor a alu_repos.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example
before changes
after changes