Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full GitHub app authentication #1986
Support full GitHub app authentication #1986
Changes from 8 commits
885a522
a719746
c39a183
d8b20e1
30a11a0
c15de72
f8a071b
e957467
add6683
3ba6e76
8df28e9
a461e0e
94ca7be
8e47431
a9c2f81
b88f36f
8534fe9
d502f27
350911e
15f1c0c
99e6b3a
ceb8d7d
df38766
8899a9e
38fb3cd
2c106c6
ce199bf
a50aecd
0e245d0
7d61945
a7ca0cb
7dd9fa9
7e6d5b7
148c14f
3e16166
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved those here since they are used in 2 files now (
MainClass
andGithubIntegration
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing this is really difficult. Would have been better to do the refactoring (without changes) in a separate PR and base this PR on that. Then we would see only changes, not moving unchanged code around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from
MainClass
, it's already big as it is and that does not really belong there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if that does not suit you. I feel that this call is badly named
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the existing call? It should probably also state it's deprecated in the docstring. Also, it should mention the class, not just the bare function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the part I added in that file. Users having a private app with more than one installations can use this call as the main class always uses the first found installation.