Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Requester thread-safe #2052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make Requester thread-safe #2052

wants to merge 1 commit into from

Conversation

IronLung7
Copy link

HTTPSRequestsConnectionClass and HTTPRequestsConnectionClass are not thread safe.
They can be simply use one request function to do the request and not saving any URL as a member parameter.

@s-t-e-v-e-n-k
Copy link
Collaborator

I wonder if we want to refactor that method to the base class, and then we only have to change it once

@IronLung7
Copy link
Author

@s-t-e-v-e-n-k Sorry, which base class?

@s-t-e-v-e-n-k
Copy link
Collaborator

I thought there was a base class, my apologies, but maybe there should be?

@IronLung7
Copy link
Author

@s-t-e-v-e-n-k Could we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IronLung7 @s-t-e-v-e-n-k @EnricoMi