Remove enableRetry and setPoolSize from Framework #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@sfdye please consider this for reopening |
Codecov ReportBase: 98.88% // Head: 98.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2147 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 108 108
Lines 11172 11172
=======================================
Hits 11047 11047
Misses 125 125 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
EnricoMi
force-pushed
the
branch-remove-framework-methods-with-side-effects
branch
from
3072348
to
0ef2f11
Compare
|
Add setter methods like: EnricoMi@ce1bf7e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using these methods in a test has side-effects on subsequent tests.
For instance, after calling
Framework.setPoolSize(20)in testPollSize.py, all subsequent tests run withGithub.__requester.__pool_size = 20. All tests beforePoolSize.pyrun withGithub.__requester.__pool_size = None.The same holds for
Framework.enableRetry.Added a comment to avoid adding similar methods in the future (as I was about to do for
per_page, which escaped and broke all subsequent tests).