Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get events not returning user events #2172

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ncareau
Copy link

@ncareau ncareau commented Feb 11, 2022

The get_events() function from the AuthenticatedUser class doesn't return events of only the user, it returns all events.

I have modified the function to return user events only, with a flag on getting Private and Public events (False, Default), or just Public events (True).

The original functionality is covered by Github.get_events().

@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 28, 2022
@ncareau
Copy link
Author

ncareau commented Apr 28, 2022

Still an issue.

@stale stale bot removed the stale label Apr 28, 2022
@hellkite500
Copy link

This definitely feels like a bug in the mapping of the python objects to the API, given that there is a /users event end point and a generic, public /events endpoint. I was about to open an issue about this exact issue and found this PR. If an issue would be be useful I'll create one to link to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants