New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for environments #2223
Conversation
The linter CI run failed, but the failure is that git is prompting for credentials to clone some packages from Gitlab. So that does not look related to my changes in any way, since I didn't touch the build or requirements files. Locally I get the same error with PyGithub:master. |
I would love to see this merged somehow! |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2223 +/- ##
==========================================
- Coverage 98.49% 98.48% -0.01%
==========================================
Files 124 128 +4
Lines 12418 12612 +194
==========================================
+ Hits 12231 12421 +190
- Misses 187 191 +4
☔ View full report in Codecov by Sentry. |
Same, I'm very interested in this feature ! |
258e1a6
to
6f5c026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We are migrating away from .pyi
files. Can you please merge all typing information from new .pyi
files (so not Repository.pyi
) into the corresponding .py
files? This will help not building up tech debt.
@EnricoMi Thanks for your review! I merged the types into the .py files for the new files I created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Environments are a feature in Github that allows setting up deployment rules, like manual approval, per repository. Because they can only be configured per repository, this makes automating their management particularly important for many-repository micro-service application. This PR adds support for getting, creating, updating and deleting environments as documented here.
This partially implements the features requested by issue 2067 (environments, but not environment secrets).