-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manage require_last_push_approval and allow_deletions in branch protection #2716
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2716 +/- ##
==========================================
- Coverage 96.74% 96.73% -0.01%
==========================================
Files 139 139
Lines 14184 14214 +30
==========================================
+ Hits 13722 13750 +28
- Misses 462 464 +2
☔ View full report in Codecov by Sentry. |
82d98c4
to
17a1a18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have tests for the new fields?
ffc42cf
to
6badde8
Compare
Added/updated tests for the new fields in the latest commits |
6badde8
to
4f7820d
Compare
@EnricoMi I have added the allow_deletion function and added tests, I also resolved a merge conflict. This PR is ready for review. |
Superseded by #2873, added you as co-author to appreciate your contribution. |
fixes #2360