-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing attributes to BranchProtection
Jan 2024
#2793
Add missing attributes to BranchProtection
Jan 2024
#2793
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
=======================================
Coverage 96.69% 96.70%
=======================================
Files 142 142
Lines 14533 14568 +35
=======================================
+ Hits 14053 14088 +35
Misses 480 480 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are there, can you add all other missing attributes as well, please?
https://docs.github.com/en/rest/branches/branch-protection#get-branch-protection
required_conversation_resolution
to BranchProtection
BranchProtection
Jan 2024
"Hi @jodelasur, we're interested in adopting these functionalities. Could you expedite the merging of the pull requests, or do you have any suggestions for directly incorporating these modules? Thanks!" |
@JayChanggithub , waiting for further review from @EnricoMi to have this merged. |
also fixes #2373 in my opinion. well, maybe not fully... question @jodelasur:
or also editing branch protection for these fields via e.g.
while testing for me it seams that only 1. is added with this PR |
Superseded by #2873, added you as co-author to appreciate your contribution. |
Fixes #2862. Also added other missing attributes.
All attributes added:
allow_force_pushes
allow_deletions
required_conversation_resolution
lock_branch
allow_fork_syncing
Used
scripts/add_attribute
and added attribute tests accordingly using existing replay data.