Link Commit to correct upstream documentation #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`github.Commit.Commit` represents a github-level commit, but the link is to git-level commits. The semantics and *especially* the metadata are very different between the two e.g. a github-level commit provodes the *github users* for the author and committer, as well as links to the github comments. The github-level commit is a layer around the git-level commit, which is (partially) provided via the `commit` attribute.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2936 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 147 147
Lines 14978 14978
=======================================
Hits 14491 14491
Misses 487 487 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.Commit.Commitrepresents a github-level commit, but the link is to git-level commits. The semantics and especially the metadata are very different between the two e.g. a github-level commit provodes the github users for the author and committer, as well as links to the github comments.The github-level commit is a layer around the git-level commit, which is (partially) provided via the
commitattribute.