Make Commit.files return PaginatedList #2939
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarspider
force-pushed
the
commit-files-paginated
branch
3 times, most recently
from
7974fbd
to
ba323d6
Compare
iarspider
force-pushed
the
commit-files-paginated
branch
from
58f9d73
to
3d551bf
Compare
EnricoMi
reviewed
Apr 19, 2024
| @@ -97,15 +97,6 @@ def testBadAttributeInClassAttribute(self): | |||
| owner.avatar_url | |||
| self.assertEqual(raisedexp.exception.actual_value, 42) | |||
|
|
|||
| def testBadTransformedAttributeInList(self): | |||
There was a problem hiding this comment.
I think instead of removing this test case, we should find a different object that returns a list of a class and use that to test the bad transform case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/commits/{ref}endpoint is paginated, meaning you can get up to 3000 files per commit:As suggested here.