Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for BadCredentialsException #2973

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Lslightly
Copy link

@Lslightly Lslightly commented May 19, 2024

add documentations for easier root cause localization. Summary for #1753 and #2955

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (7266e81) to head (4f89110).
Report is 1 commits behind head on main.

Current head 4f89110 differs from pull request most recent head 1fadb37

Please upload reports for the commit 1fadb37 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
- Coverage   96.74%   96.73%   -0.02%     
==========================================
  Files         147      147              
  Lines       14978    14984       +6     
==========================================
+ Hits        14491    14495       +4     
- Misses        487      489       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lslightly
Copy link
Author

I find bad looks in readthedocs but I am not familiar with readthedocs.

But the headings work well in vscode python extension when hovering over BadCredentialsException.

image

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest the following improvements in these instructions.

github/GithubException.py Show resolved Hide resolved
github/GithubException.py Outdated Show resolved Hide resolved
github/GithubException.py Outdated Show resolved Hide resolved
github/GithubException.py Outdated Show resolved Hide resolved
github/GithubException.py Outdated Show resolved Hide resolved
Lslightly and others added 6 commits May 21, 2024 16:01
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants