Add support for getting / replacing topics (#634) #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
commented
Jul 5, 2018
github/tests/Repository.py
Outdated
| self.assertEquals(topic in topic_list, True) | ||
|
|
||
| def testReplaceTopics(self): | ||
| self.repo.replace_topics(['github', 'testing']) |
There was a problem hiding this comment.
Looking at some of the other tests, I think no assertion is needed here? Let me know if this needs to be improved.
sfdye
reviewed
Jul 6, 2018
| @@ -2426,6 +2446,22 @@ def protect_branch(self, branch, enabled, enforcement_level=github.GithubObject. | |||
| input=post_parameters | |||
| ) | |||
|
|
|||
| def replace_topics(self, topics): | |||
| """ | |||
| :calls: `PUT /repos/:owner/:repo/topics <http://developer.github.com/v3/repos>`_ | |||
There was a problem hiding this comment.
sfdye
reviewed
Jul 6, 2018
github/Repository.py
Outdated
| @@ -2304,6 +2312,18 @@ def get_teams(self): | |||
| None | |||
| ) | |||
|
|
|||
| def get_topics(self): | |||
| """ | |||
| :calls: `GET /repos/:owner/:repo/topics <http://developer.github.com/v3/repos>`_ | |||
There was a problem hiding this comment.
Let's add the exact link:
https://developer.github.com/v3/repos/#list-all-topics-for-a-repository
sfdye
reviewed
Jul 6, 2018
github/tests/Repository.py
Outdated
| def testGetTopics(self): | ||
| topic_list = self.repo.get_topics() | ||
| topic = u'github' | ||
| self.assertEquals(topic in topic_list, True) |
sfdye
reviewed
Jul 6, 2018
github/Repository.py
Outdated
| @property | ||
| def topics(self): | ||
| """ | ||
| :type: list |
wyardley
force-pushed
the
wyardley-rework_635_2
branch
from
c5e8d74
to
1cc3832
Compare
|
@sfdye Thanks for the review feedback, I think I addressed your points -- let me know how that looks. |
sfdye
approved these changes
Jul 6, 2018
|
@wyardley Thank you very much for putting this together. Merged! |
Closed
candrikos
pushed a commit
to candrikos/PyGithub
that referenced
this pull request
Sep 25, 2020
* Add support for getting and replacing topics on a repository PyGithub#634 * Add / fix tests, accept list vs dict for replace_topics (PyGithub#634)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly @peterkline's work, just trying to replace #635 (which hasn't been updated) and adjust for some of the changes requested / discussed there.
This seems to resolves the existing test failure, and I think resolves most of the other feedback in the other PR. It also switches the input to
replace_topics()to the expected array as discussed. Would appreciate feedback, esp. on the test case I added. Because there's no expected return from the method, I think that test is acceptable as-is? I'm not that familiar with this module's test setup, though, so let me know if I should update anything.I didn't have much luck rebasing, so I just patched, but I did retain original author on the first commit.
cc @sfdye