Add missing arguments to Repository.edit #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquerie
commented
Jul 14, 2018
| @@ -4,10 +4,10 @@ api.github.com | |||
| None | |||
| /repos/jacquev6/PyGithub | |||
| {'Content-Type': 'application/json', 'Authorization': 'Basic login_and_password_removed', 'User-Agent': 'PyGithub/Python'} | |||
| {"has_wiki": false, "name": "PyGithub", "has_downloads": true, "has_issues": true, "homepage": "http://vincent-jacques.net/PyGithub", "private": true, "description": "Description edited by PyGithub"} | |||
| {"has_wiki": false, "name": "PyGithub", "has_downloads": true, "has_issues": true, "homepage": "http://vincent-jacques.net/PyGithub", "private": true, "description": "Description edited by PyGithub", "has_projects": false, "allow_squash_merge": true, "allow_merge_commit": true, "allow_rebase_merge": true} | |||
There was a problem hiding this comment.
Manually editing the request/response pair is error prone and ugly, but it is necessitated by the fact that self.repo in the test points to a repository nobody else has the correct rights to, so whenever one needs to modify one of the existing tests there's no way to just re-record the exchange.
sfdye
approved these changes
Jul 15, 2018
jacquerie
added a commit
to jacquerie/PyGithub
that referenced
this pull request
Sep 16, 2018
Allows to pass falsy values to the new arguments introduced in PyGithub#844. Closes PyGithub#903
Merged
sfdye
pushed a commit
that referenced
this pull request
Sep 16, 2018
candrikos
pushed a commit
to candrikos/PyGithub
that referenced
this pull request
Sep 25, 2020
As promised in PyGithub#842, here's a PR to update the `edit` method so that it allows editing the newly added properties.
candrikos
pushed a commit
to candrikos/PyGithub
that referenced
this pull request
Sep 25, 2020
Allows to pass falsy values to the new arguments introduced in PyGithub#844. Closes PyGithub#903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #842, here's a PR to update the
editmethod so that it allows editing the newly added properties.