Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new attributes to IssueEvent #857

Merged
merged 15 commits into from
Aug 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions github/Consts.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,6 @@

# https://developer.github.com/changes/2018-02-22-label-description-search-preview/
mediaTypeLabelDescriptionSearchPreview = "application/vnd.github.symmetra-preview+json"

# https://developer.github.com/changes/2018-01-10-lock-reason-api-preview/
mediaTypeLockReasonPreview = "application/vnd.github.sailor-v-preview+json"
3 changes: 2 additions & 1 deletion github/Issue.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,8 @@ def get_events(self):
github.IssueEvent.IssueEvent,
self._requester,
self.url + "/events",
None
None,
headers={'Accept': Consts.mediaTypeLockReasonPreview}
)

def get_labels(self):
Expand Down
129 changes: 129 additions & 0 deletions github/IssueEvent.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,102 @@ def url(self):
self._completeIfNotSet(self._url)
return self._url.value

@property
def node_id(self):
"""
:type: string
"""
self._completeIfNotSet(self._node_id)
return self._node_id.value

@property
def commit_url(self):
"""
:type: string
"""
self._completeIfNotSet(self._commit_url)
return self._commit_url.value

@property
def label(self):
"""
:type: :class:`github.Label.Label`
"""
self._completeIfNotSet(self._label)
return self._label.value

@property
def assignee(self):
"""
:type: :class:`github.NamedUser.NamedUser`
"""
self._completeIfNotSet(self._assignee)
return self._assignee.value

@property
def assigner(self):
"""
:type: :class:`github.NamedUser.NamedUser`
"""
self._completeIfNotSet(self._assigner)
return self._assigner.value

@property
def review_requester(self):
"""
:type: :class:`github.NamedUser.NamedUser`
"""
self._completeIfNotSet(self._review_requester)
return self._review_requester.value

@property
def requested_reviewer(self):
"""
:type: :class:`github.NamedUser.NamedUser`
"""
self._completeIfNotSet(self._requested_reviewer)
return self._requested_reviewer.value

@property
def milestone(self):
"""
:type: :class:`github.Milestone.Milestone`
"""
self._completeIfNotSet(self._milestone)
return self._milestone.value

@property
def rename(self):
"""
:type: dict
"""
self._completeIfNotSet(self._rename)
return self._rename.value

@property
def rename(self):
"""
:type: dict
"""
self._completeIfNotSet(self._rename)
return self._rename.value

@property
def dismissed_review(self):
"""
:type: dict
"""
self._completeIfNotSet(self._dismissed_review)
return self._dismissed_review.value

@property
def lock_reason(self):
"""
:type: string
"""
self._completeIfNotSet(self._lock_reason)
return self._lock_reason.value

def _initAttributes(self):
self._actor = github.GithubObject.NotSet
self._commit_id = github.GithubObject.NotSet
Expand All @@ -109,6 +205,17 @@ def _initAttributes(self):
self._id = github.GithubObject.NotSet
self._issue = github.GithubObject.NotSet
self._url = github.GithubObject.NotSet
self._node_id = github.GithubObject.NotSet
self._commit_url = github.GithubObject.NotSet
self._label = github.GithubObject.NotSet
self._assignee = github.GithubObject.NotSet
self._assigner = github.GithubObject.NotSet
self._review_requester = github.GithubObject.NotSet
self._requested_reviewer = github.GithubObject.NotSet
self._milestone = github.GithubObject.NotSet
self._rename = github.GithubObject.NotSet
self._dismissed_review = github.GithubObject.NotSet
self._lock_reason = github.GithubObject.NotSet

def _useAttributes(self, attributes):
if "actor" in attributes: # pragma no branch
Expand All @@ -125,3 +232,25 @@ def _useAttributes(self, attributes):
self._issue = self._makeClassAttribute(github.Issue.Issue, attributes["issue"])
if "url" in attributes: # pragma no branch
self._url = self._makeStringAttribute(attributes["url"])
if "node_id" in attributes: # pragma no branch
self._node_id = self._makeStringAttribute(attributes["node_id"])
if "commit_url" in attributes: # pragma no branch
self._commit_url = self._makeStringAttribute(attributes["commit_url"])
if "label" in attributes: # pragma no branch
self._label = self._makeClassAttribute(github.Label.Label, attributes["label"])
if "assignee" in attributes: # pragma no branch
self._assignee = self._makeClassAttribute(github.NamedUser.NamedUser, attributes["assignee"])
if "assigner" in attributes: # pragma no branch
self._assigner = self._makeClassAttribute(github.NamedUser.NamedUser, attributes["assigner"])
if "review_requester" in attributes: # pragma no branch
self._review_requester = self._makeClassAttribute(github.NamedUser.NamedUser, attributes["review_requester"])
if "requested_reviewer" in attributes: # pragma no branch
self._requested_reviewer = self._makeClassAttribute(github.NamedUser.NamedUser, attributes["requested_reviewer"])
if "milestone" in attributes: # pragma no branch
self._milestone = self._makeClassAttribute(github.Milestone.Milestone, attributes["milestone"])
if "rename" in attributes: # pragma no branch
self._rename = self._makeDictAttribute(attributes["rename"])
if "dismissed_review" in attributes: # pragma no branch
self._dismissed_review = self._makeDictAttribute(attributes["dismissed_review"])
if "lock_reason" in attributes: # pragma no branch
self._lock_reason = self._makeStringAttribute(attributes["lock_reason"])
6 changes: 4 additions & 2 deletions github/Repository.py
Original file line number Diff line number Diff line change
Expand Up @@ -1925,7 +1925,8 @@ def get_issues_event(self, id):
assert isinstance(id, (int, long)), id
headers, data = self._requester.requestJsonAndCheck(
"GET",
self.url + "/issues/events/" + str(id)
self.url + "/issues/events/" + str(id),
headers={'Accept': Consts.mediaTypeLockReasonPreview}
)
return github.IssueEvent.IssueEvent(self._requester, headers, data, completed=True)

Expand All @@ -1938,7 +1939,8 @@ def get_issues_events(self):
github.IssueEvent.IssueEvent,
self._requester,
self.url + "/issues/events",
None
None,
headers={'Accept': Consts.mediaTypeLockReasonPreview}
)

def get_key(self, id):
Expand Down