Add allow_redirects option #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind removing the diff introduced by the linter, so we can focus the purpose of this PR? |
|
This was a long code to review and not sure where you were to work on. The linter made the diff longer which I don't think it was the purpose of the PR. |
|
@djstein I would like to make a new release, if we can get this merged. |
|
Only the changes on line 107 and 133 are relevant; @sfdye I think as maintainer I believe you are able to edit the PR. |
|
@mfonville Yeah technically I can, but I don't want to modify someone else's branch without asking them first. So @djstein do you mind? |
|
@sfdye auto formatting has been removed |
sfdye
approved these changes
Aug 19, 2018
|
@sfdye when do we see a build of this going out? |
|
Until #872 progresses, my hands are tied 😞 |
|
1.43 is out. |
candrikos
pushed a commit
to candrikos/PyGithub
that referenced
this pull request
Sep 25, 2020
Fixes PyGithub#830 Latest release v1.40 has broken get_archive_link PyGithub#830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #830
Latest release v1.40 has broken get_archive_link
#830