Add examples for searching repositories (#874) #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfdye
reviewed
Oct 8, 2018
doc/examples/MainClass.rst
Outdated
| ... print(repo.html_url) | ||
| ... | ||
| https://github.com/vinta/awesome-python |
There was a problem hiding this comment.
To have a consistent format, maybe you can just print(repo) instead, and let the repr() do its job?
There was a problem hiding this comment.
@sfdye ok. My thinking was that as a user I would want to have the full repo urls.
There was a problem hiding this comment.
Got it. As a getting-started guide, we try to make it as generic as possible.
sfdye
reviewed
Oct 8, 2018
doc/examples/MainClass.rst
Outdated
| ... print(repo.html_url) | ||
| ... | ||
| 'https://github.com/aws-amplify/amplify-js' |
There was a problem hiding this comment.
Same here, print(repo) should be enough
use repr to display objects
sfdye
approved these changes
Oct 8, 2018
candrikos
pushed a commit
to candrikos/PyGithub
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.