Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New use examples #920

Merged
merged 3 commits into from
Oct 8, 2018
Merged

New use examples #920

merged 3 commits into from
Oct 8, 2018

Conversation

mstuttgart
Copy link
Contributor

This PR add the follow code examples

  • Issue examples (get list, get specific issue, create issue)
  • Milestone examples (get list, get specific milestone, create milestone)

Ref.: #874

sfdye
sfdye requested changes Oct 8, 2018
View reviewed changes
Copy link
Member

@sfdye sfdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Since you are adding new filea, you need to add them to examples.rst which serves as a the table of contents.

@mstuttgart
Copy link
Contributor Author

@sfdye links added 👍

sfdye
sfdye reviewed Oct 8, 2018
View reviewed changes
doc/examples/Issue.rst Outdated

.. code-block:: python

>>> repo = g.get_repo("PyGithub/PyGithub")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it's more appropriate to put this example under Repository.rst, since it's getting repo issues. Other example here is fine. Or simply keep both :)

@mstuttgart
Copy link
Contributor Author

@sfdye done 👍

@sfdye sfdye merged commit 228e5e8 into PyGithub:master Oct 8, 2018
@mstuttgart mstuttgart deleted the new_examples branch October 8, 2018 12:34
candrikos pushed a commit to candrikos/PyGithub that referenced this pull request Sep 25, 2020
@mstuttgart @candrikos
New use examples (PyGithub#920)
f3b7dc5 
This PR add the follow code examples

* Issue examples (get list, get specific issue, create issue)
* Milestone examples (get list, get specific milestone, create milestone)

Ref.: PyGithub#874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfdye sfdye sfdye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstuttgart @sfdye