Fix FileVideoStream NoneType error when reaching end of file #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the FileVideoStream class to read a video file, reaching the end of the file raises an error similar to the following:
This is because the last frame returned by
FileVideoStream.read()
is not actually a frame, butNone
.Solution
When the end of the video file has been reached, the
frame
variable containsNone
(line 47). In this case, the frame should not be added to the queue.The transform function shouldn't be executed either, as we're not sure whether this user-specified function can handle
None
as input for the frame.