Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podporovat Flask 3 nebo omezit verzi v závislostech #733

Closed
befeleme opened this issue Oct 3, 2023 · 1 comment · Fixed by #734
Closed

Podporovat Flask 3 nebo omezit verzi v závislostech #733

befeleme opened this issue Oct 3, 2023 · 1 comment · Fixed by #734

Comments

@befeleme
Copy link
Contributor

befeleme commented Oct 3, 2023

Naše stránky se nedají vytvořit s Flaskem 3.0.0.
Je třeba buď zjistit, co se rozbilo a přizpůsobit kód novému Flasku, nebo omezit verzi v závislostech.

CI failuje s:

Run python pyladies_cz.py freeze --verbose
Traceback (most recent call last):
Generating HTML...
  File "/home/runner/work/pyladies.cz/pyladies.cz/pyladies_cz.py", line 329, in <module>
    cli(app, freezer=freezer, base_url='http://pyladies.cz/')
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/elsa/_cli.py", line 174, in cli
    return command()
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/elsa/_cli.py", line 125, in freeze
    freeze_app(app, freezer, path, base_url, verbose=verbose)
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/elsa/_cli.py", line 56, in freeze_app
    for page in freezer.freeze_yield():
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/flask_frozen/__init__.py", line 183, in freeze_yield
    for url, endpoint, last_modified in self._generate_all_urls():
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/flask_frozen/__init__.py", line 232, in _generate_all_urls
    url_encoding = self.app.url_map.charset
AttributeError: 'Map' object has no attribute 'charset'
Error: Process completed with exit code 1.
@encukou
Copy link
Member

encukou commented Oct 3, 2023

Problém je ve Frozen-Flask/Frozen-Flask#129, ale Frozen-Flask teď nemá maintainera :(
Dá se použít Flask<3.0, opravit Frozen-Flask, nebo přejít na Freezeyt :)

befeleme added a commit to befeleme/pyladies.cz that referenced this issue Oct 13, 2023
frenzymadness pushed a commit that referenced this issue Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants