Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchlight hyperalignment tests fails sometimes #455

Closed
nno opened this issue Apr 10, 2016 · 5 comments
Closed

searchlight hyperalignment tests fails sometimes #455

nno opened this issue Apr 10, 2016 · 5 comments

Comments

@nno
Copy link
Contributor

nno commented Apr 10, 2016

Running travis for PR #454, the following test sometimes fails [1]:

======================================================================
FAIL: test_searchlight_hyperalignment (mvpa2.tests.test_searchlight_hyperalignment.SearchlightHyperalignmentTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/nno/PyMVPA/mvpa2/testing/tools.py", line 331, in newfunc
    return func(*arg, **kwargs)
  File "/home/travis/build/nno/PyMVPA/mvpa2/tests/test_searchlight_hyperalignment.py", line 245, in test_searchlight_hyperalignment
    assert(np.sum(max_weight == diag_weight) / float(len(diag_weight)) > 0.98)
AssertionError

Ping @swaroopgj
[1] https://travis-ci.org/nno/PyMVPA/jobs/122044397

@swaroopgj
Copy link
Member

@nno Thanks Nick. It's an issue with the test being stringent. Will send a PR soon.

@nno
Copy link
Contributor Author

nno commented Apr 11, 2016

Thanks @swaroopgj, looking forward to the PR (but no rush) :-)

@yarikoptic
Copy link
Member

Was fixed by #456

@nno
Copy link
Contributor Author

nno commented May 20, 2016

It fails occasionally with

assert(np.sum(max_weight == diag_weight) / float(len(diag_weight)) > 0.90)

can we use a value lower than 0.90 @swaroopgj?

See: https://travis-ci.org/PyMVPA/PyMVPA/jobs/131643694

@swaroopgj
Copy link
Member

swaroopgj commented May 20, 2016

Thanks Nick. Relaxed the test values for a few tests. Hopefully, this will make them pass for almost all cases.
@yarikoptic Made a PR #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants