Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS-12 built wheel incompatible with macOS-11, but Still has macosx_11_0 tag #1247

Closed
Congyuwang opened this issue Nov 4, 2022 · 3 comments · Fixed by #1251
Closed

macOS-12 built wheel incompatible with macOS-11, but Still has macosx_11_0 tag #1247

Congyuwang opened this issue Nov 4, 2022 · 3 comments · Fixed by #1251
Labels
bug Something isn't working

Comments

@Congyuwang
Copy link

macOS-12 packaging environment gives macosx_10_9_x86_64.macosx_11_0_arm64.macosx_10_9_universal2.whl, which turns out incompatible with macOS 11 because of Symbol not found in /usr/lib/libc++.1.dylib.

I think perhaps wheels built on macOS-12 should be tagged macosx_12_0, and therefore not to be downloaded by pypi to macOS-11.
@Congyuwang Congyuwang added the enhancement New feature or request label Nov 4, 2022
@messense
Copy link
Member

messense commented Nov 4, 2022

I assume you have C++ dependencies? Then you should set MACOSX_DEPLOYMENT_TARGET, rustc uses 11.0.

@messense messense mentioned this issue Nov 5, 2022
Merged
bors bot added a commit that referenced this issue Nov 5, 2022
@bors @messense
Merge #1251
1096460 
1251: Set default macOS deployment target version if not specified r=messense a=messense

Fixes #1247 

Co-authored-by: messense <messense@icloud.com>
@messense
Copy link
Member

messense commented Nov 5, 2022 •
edited

Generating tag based on the dylib build version is pending on m4b/goblin#341

Tracked in #1252

@bors bors bot closed this as completed in e74b2a8 Nov 5, 2022
@messense messense added bug Something isn't working and removed enhancement New feature or request labels Nov 7, 2022
@messense messense mentioned this issue Dec 30, 2022
Closed
@happy-machine
Copy link

Hey, this is using the maturin github action ... shouldn't that build for both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set default macOS deployment target version if not specified messense/maturin
3 participants
@messense @happy-machine @Congyuwang