Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default macOS deployment target version if not specified #1251

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Set default macOS deployment target version if not specified #1251

merged 1 commit into from
Nov 5, 2022

Conversation

messense
Copy link
Member

@messense messense commented Nov 5, 2022

Fixes #1247

@netlify
Copy link

netlify bot commented Nov 5, 2022 •
edited
Loading

✅ Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 134f424
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63661e943cdc0d0008f7f2cc
😎 Deploy Preview https://deploy-preview-1251--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense force-pushed the default-macos-deployment-target-version branch from ad46119 to 134f424 Compare November 5, 2022 08:28
@messense
Copy link
Member Author

messense commented Nov 5, 2022

bors r+

bors bot added a commit that referenced this pull request Nov 5, 2022
@bors @messense
Merge #1251
1096460 
1251: Set default macOS deployment target version if not specified r=messense a=messense

Fixes #1247 

Co-authored-by: messense <messense@icloud.com>
@bors
Copy link
Contributor

bors bot commented Nov 5, 2022

Build failed:

@messense
Copy link
Member Author

messense commented Nov 5, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 5, 2022

Build succeeded:

@bors bors bot merged commit e74b2a8 into PyO3:main Nov 5, 2022
@messense messense added this to the 0.14.0 milestone Nov 11, 2022
@messense messense deleted the default-macos-deployment-target-version branch November 14, 2022 04:16
@messense messense mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

macOS-12 built wheel incompatible with macOS-11, but Still has macosx_11_0 tag
1 participant
@messense