Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate python-source option in Cargo.toml #1291

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

messense
Copy link
Member

The sdist generation code assumes it's relative to pyproject.toml, to keep it simple, let's deprecate the option in Cargo.toml and only support it in pyproject.toml.

Fixes #1290

@messense messense added the sdist Source distribution label Nov 23, 2022
@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 49468cf
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/637d9840310cd70008b556a6
😎 Deploy Preview https://deploy-preview-1291--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 23, 2022

@bors bors bot merged commit 73eb351 into PyO3:main Nov 23, 2022
@messense messense deleted the python-source branch November 23, 2022 04:35
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Nov 25, 2022
https://build.opensuse.org/request/show/1038001
by user mia + dimstar_suse
- Update to v0.14.2:
  * Tighten src-layout detection logic
    gh#PyO3/maturin#1282
  * Update cargo_metadata to 0.15.2
    gh#PyO3/maturin#1284
  * Tell people about setting RUST_LOG=maturin=debug when making
    bug reports
    gh#PyO3/maturin#1286
  * Fix generating pep517 sdist for src-layout
    gh#PyO3/maturin#1288
  * Deprecate python-source option in Cargo.toml
    gh#PyO3/maturin#1291
  * Fix auditwheel with read-only libraries
    gh#PyO3/maturin#1292
  * CI: Try nextest double spawn feature
    gh#PyO3/maturin#1294
  * Update wasmtime dependency version to 3.0.0
    gh#PyO3/maturin#1295
- Changes in v0.14.1:
  * Downgrade cargo_metadata to 0.15.0
    gh#PyO3/maturin#1279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdist Source distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maturin build fails with --sdist, succeeds without
1 participant