Fix auditwheel with read-only libraries #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
vlaci
commented
Nov 23, 2022
messense
approved these changes
Nov 23, 2022
bors bot
added a commit
that referenced
this pull request
Nov 23, 2022
1292: add_external_libs: ensure write permission on libraries r=messense a=vlaci `std::fs::copy` also copies the original file permissions. If the original library at `lib_path` was not writable, e.g. because it had its permission set to 0o555, the copy inherited the same permission causing later file manipulations, like `patchelf --set-soname` to fail. Fixes #1287 Co-authored-by: László Vaskó <1771332+vlaci@users.noreply.github.com>
vlaci
changed the title
`std::fs::copy` also copies the original file permissions. If the original library at `lib_path` was not writable, e.g. because it had its permission set to 0o555, the copy inherited the same permission causing later file manipulations, like `patchelf --set-soname` to fail.
vlaci
force-pushed
the
fix-permissions
branch
from
7882066
to
084a4e7
Compare
|
Canceled. |
|
Thanks for adding the changelog entry. bors retry |
|
Thanks for the fast response. |
|
Build succeeded: |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 25, 2022
https://build.opensuse.org/request/show/1038001 by user mia + dimstar_suse - Update to v0.14.2: * Tighten src-layout detection logic gh#PyO3/maturin#1282 * Update cargo_metadata to 0.15.2 gh#PyO3/maturin#1284 * Tell people about setting RUST_LOG=maturin=debug when making bug reports gh#PyO3/maturin#1286 * Fix generating pep517 sdist for src-layout gh#PyO3/maturin#1288 * Deprecate python-source option in Cargo.toml gh#PyO3/maturin#1291 * Fix auditwheel with read-only libraries gh#PyO3/maturin#1292 * CI: Try nextest double spawn feature gh#PyO3/maturin#1294 * Update wasmtime dependency version to 3.0.0 gh#PyO3/maturin#1295 - Changes in v0.14.1: * Downgrade cargo_metadata to 0.15.0 gh#PyO3/maturin#1279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::fs::copyalso copies the original file permissions. If the original library atlib_pathwas not writable, e.g. because it had its permission set to 0o555, the copy inherited the same permission causing later file manipulations, likepatchelf --set-sonameto fail.Fixes #1287