Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reddit problems #751

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Fix reddit problems #751

merged 4 commits into from
Dec 20, 2021

Conversation

konstin
Copy link
Member

@konstin konstin commented Dec 20, 2021

Some wrote on r/rust about some confusions with maturin. These changes fix the two I found actionable.

@netlify
Copy link

netlify bot commented Dec 20, 2021

✔️ Deploy Preview for maturin-guide canceled.

🔨 Explore the source changes: 483546d

🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/61bff413f8b8a5000874a134

src/metadata.rs Outdated Show resolved Hide resolved
@messense
Copy link
Member

messense commented Dec 20, 2021

BTW I'd like to cleanup Readme.md and point users to the read the guide instead later.

I'm thinking about making the Readme.md structure similar to https://github.com/PyO3/pyo3/blob/main/README.md

@konstin
Copy link
Member Author

konstin commented Dec 20, 2021

Sounds good, just please make sure that the manylinux/auditwheel story is highlighted in a way that says "you have to take care of this before publishing to pypi"

tests/common/other.rs Outdated Show resolved Hide resolved
@konstin konstin merged commit fa66292 into main Dec 20, 2021
@konstin konstin deleted the fix-reddit-problems branch December 20, 2021 03:21
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Jan 3, 2022
* Add support for repairing cross compiled linux wheels in [#754](PyO3/maturin#754)
* Add support for `manylinux_2_28` and `manylinux_2_31` in [#755](PyO3/maturin#755)
* Remove existing so file first in `maturin develop` command to avoid triggering SIGSEV in running process in [#760](PyO3/maturin#760)

* Fix docs for `new` and `init` commands in `maturin --help` in [#734](PyO3/maturin#734)
* Add support for x86_64 Haiku in [#735](PyO3/maturin#735)
* Fix undefined auditwheel policy panic in [#740](PyO3/maturin#740)
* Fix sdist upload for packages where the pkgname contains multiple underscores in [#741](PyO3/maturin#741)
* Implement auditwheel repair with patchelf in [#742](PyO3/maturin#742)
* Add `Cargo.lock` to sdist when `--locked` or `--frozen` specified in [#749](PyO3/maturin#749)
* Infer readme file if not specified in [#751](PyO3/maturin#751)

* Add a `maturin init` command as a companion to `maturin new` in [#719](PyO3/maturin#719)
* Don't package non-path-dep crates in sdist for workspaces in [#720](PyO3/maturin#720)
* Build release packages with `password-storage` feature in [#725](PyO3/maturin#725)
* Add support for x86_64 DargonFly BSD in [#727](PyO3/maturin#727)
* Add a Python import hook in [#729](PyO3/maturin#729)
* Allow pip warnings in `maturin develop` command in [#732](PyO3/maturin#732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants