Implement auditwheel repair with patchelf #742
Conversation
|
✔️ Deploy Preview for maturin-guide canceled. 🔨 Explore the source changes: 1af539a 🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/61bf28a28ef35e00075972af |
There was a problem hiding this comment.
This is fancy!
The code isn't well organized yet, but hey it works™.
I couldn't even implement this, I'm happy that you're doing that :D
One other thing I've noticed is https://github.com/messense/lddtree-rs/blob/aa3ba6af1c7e00b1d084596fecc82dc3886a1a34/src/lib.rs#L138. Would this mean that a bogus lib could silently lead to a broken wheel?
BTW have you seen https://twitter.com/andy_kelley/status/1470338795266457600? It's not ready yet, but if it's completed we could drop the docker container and just compile for manylinux2010 directly. Also zig cc is on pypi so we could just list it as a dependency.
| "Error checking for manylinux/musllinux compliance".to_string() | ||
| } | ||
| })?; | ||
| let external_libs = if should_repair && !self.editable { |
There was a problem hiding this comment.
Is this even executed for editable installs?
There was a problem hiding this comment.
I shouldn't, I was being defensive there.
Thanks for reporting. I forgot to remove that in messense/lddtree-rs@28d4c27#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759 now that it uses a placeholder Edit: fixed in messense/lddtree-rs@fdf698d |
I have seen that. Hopefully when it's ready it can be used when C++ is not involved! |
|
Hmm, looks like Python 3.10.1 is broken. |
Co-authored-by: konstin <konstin@mailbox.org>
https://build.opensuse.org/request/show/942187 by user mia + dimstar_suse - Update to 0.12.5 * Fix docs for new and init commands in maturin --help gh#PyO3/maturin#734 * Fix undefined auditwheel policy panic gh#PyO3/maturin#740 * Fix upload::canonicalize_name() regex subst gh#PyO3/maturin#741 * Bump serde from 1.0.130 to 1.0.131 gh#PyO3/maturin#745 * Bump sha2 from 0.9.8 to 0.10.0 gh#PyO3/maturin#746 * Add Cargo.lock to sdist when --locked or --frozen specified gh#PyO3/maturin#749 * Implement auditwheel repair with patchelf gh#PyO3/maturin#742 * Support pyo3 abi3-py310 feature gh#PyO3/maturin#750 - Changes in 0.12.4: * Bump anyhow from 1.0.50 to 1.0.51 gh#PyO3/maturin#717 * init: new command similar to cargo init gh#PyO3/maturin#719 * Don't package non-path-dep crates in sdist for workspaces gh#PyO
* Add support for repairing cross compiled linux wheels in [#754](PyO3/maturin#754) * Add support for `manylinux_2_28` and `manylinux_2_31` in [#755](PyO3/maturin#755) * Remove existing so file first in `maturin develop` command to avoid triggering SIGSEV in running process in [#760](PyO3/maturin#760) * Fix docs for `new` and `init` commands in `maturin --help` in [#734](PyO3/maturin#734) * Add support for x86_64 Haiku in [#735](PyO3/maturin#735) * Fix undefined auditwheel policy panic in [#740](PyO3/maturin#740) * Fix sdist upload for packages where the pkgname contains multiple underscores in [#741](PyO3/maturin#741) * Implement auditwheel repair with patchelf in [#742](PyO3/maturin#742) * Add `Cargo.lock` to sdist when `--locked` or `--frozen` specified in [#749](PyO3/maturin#749) * Infer readme file if not specified in [#751](PyO3/maturin#751) * Add a `maturin init` command as a companion to `maturin new` in [#719](PyO3/maturin#719) * Don't package non-path-dep crates in sdist for workspaces in [#720](PyO3/maturin#720) * Build release packages with `password-storage` feature in [#725](PyO3/maturin#725) * Add support for x86_64 DargonFly BSD in [#727](PyO3/maturin#727) * Add a Python import hook in [#729](PyO3/maturin#729) * Allow pip warnings in `maturin develop` command in [#732](PyO3/maturin#732)
Linux dylib dependency resolution built with lddtree-rs, patch dylib's
sonameandrpathis done with patchelf which means user needs to install it beforehand. Would be great if there is a pure Rust version but unfortunately I don't have the expertise to do that.The code isn't well organized yet, but hey it works™.
Closes #649