Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mixed rust/python template project layout #855

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

messense
Copy link
Member

@messense messense commented Mar 15, 2022

Helps with #335 (comment)

Before:

❯ tree hello
hello
├── Cargo.toml
├── hello
│   └── __init__.py
├── pyproject.toml
└── src
    └── lib.rs

After:

❯ tree hello
hello
├── Cargo.lock
├── Cargo.toml
├── pyproject.toml
├── python
│   └── hello
│       └── __init__.py
└── src
    └── lib.rs

@netlify
Copy link

netlify bot commented Mar 15, 2022

✔️ Deploy Preview for maturin-guide canceled.

🔨 Explore the source changes: 3ed0dd9

🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/623078ef1d9f9b0008f66bd3

@messense messense merged commit a6e8798 into PyO3:main Mar 21, 2022
@messense messense deleted the mixed-project-layout branch March 21, 2022 06:08
MusicalNinjaDad added a commit to MusicalNinjaDad/FizzBuzz that referenced this pull request May 13, 2024
MusicalNinjaDad added a commit to MusicalNinjaDad/FizzBuzz that referenced this pull request May 13, 2024
move python packages to dedicated python directory as per PyO3/maturin#855
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this pull request May 14, 2024
… projects

The previous layout leads to an import error when installing with `maturin build` and `pip install .`.

This error was common enough that `maturin` changed the recommended project layout to what this commit does.

A prior PR attempted to solve this by altering `lib.name` in Cargo.toml, but that did not work for me.

- [Prior PR](apache#694)
- [maturin ImportError issue](PyO3/maturin#490)
- [maturin changes recommended project structure](PyO3/maturin#855)
andygrove pushed a commit to apache/datafusion-python that referenced this pull request May 14, 2024
#695)

* chore: update to maturin's recommended project layout for rust/python projects

The previous layout leads to an import error when installing with `maturin build` and `pip install .`.

This error was common enough that `maturin` changed the recommended project layout to what this commit does.

A prior PR attempted to solve this by altering `lib.name` in Cargo.toml, but that did not work for me.

- [Prior PR](#694)
- [maturin ImportError issue](PyO3/maturin#490)
- [maturin changes recommended project structure](PyO3/maturin#855)

* ci: update `ruff check` for nested python directory
hohav added a commit to hohav/peppi-py that referenced this pull request Jul 6, 2024
Per PyO3/maturin#490 and
PyO3/maturin#855, this avoids problems when
importing from the project dir.
hohav added a commit to hohav/peppi-py that referenced this pull request Jul 6, 2024
Per PyO3/maturin#490 and
PyO3/maturin#855, this avoids problems when
importing from the project dir.
hohav added a commit to hohav/peppi-py that referenced this pull request Jul 6, 2024
Per PyO3/maturin#490 and
PyO3/maturin#855, this avoids problems when
importing from the project dir.
hohav added a commit to hohav/peppi-py that referenced this pull request Jul 8, 2024
Per PyO3/maturin#490 and
PyO3/maturin#855, this avoids problems when
importing from the project dir.
hohav added a commit to hohav/peppi-py that referenced this pull request Jul 15, 2024
Per PyO3/maturin#490 and
PyO3/maturin#855, this avoids problems when
importing from the project dir.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant