fixes #3561 -- silence new clippy warning

PyO3 · Nov 27, 2023 · 028066d · 028066d
1 parent 0f34fcd
commit 028066d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/newsfragments/3564.fixed.md b/newsfragments/3564.fixed.md
@@ -0,0 +1 @@
+Silenced new `clippy::unnecessary_fallible_conversions` warning when using a `Py<Self>` `self` receiver
diff --git a/pyo3-build-config/src/lib.rs b/pyo3-build-config/src/lib.rs
@@ -153,6 +153,10 @@ pub fn print_feature_cfgs() {
     if rustc_minor_version >= 74 {
         println!("cargo:rustc-cfg=invalid_from_utf8_lint");
     }
+
+    if rustc_minor_version >= 75 {
+        println!("cargo:rustc-cfg=clippy_unnecessary_fallible_conversions_lint");
+    }
 }
 
 /// Private exports used in PyO3's build.rs

diff --git a/pyo3-macros-backend/src/method.rs b/pyo3-macros-backend/src/method.rs
@@ -182,6 +182,7 @@ impl SelfType {
                             .map_err(::std::convert::Into::<_pyo3::PyErr>::into)
                             .and_then(
                                 #[allow(clippy::useless_conversion)]  // In case slf is PyCell<Self>
+                                #[allow(unknown_lints, clippy::unnecessary_fallible_conversions)]  // In case slf is Py<Self> (unknown_lints can be removed when clippy_unnecessary_fallible_conversions_lint is always available; MSRV 1.75+)
                                 |cell| ::std::convert::TryFrom::try_from(cell).map_err(::std::convert::Into::into)
                             )