Move code to a Py_3 function

PyO3 · Mar 17, 2019 · 59fd504 · 59fd504
1 parent dd8e621
commit 59fd504
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/src/type_object.rs b/src/type_object.rs
@@ -397,14 +397,7 @@ where
     let mut props = py_class_properties::<T>();
 
     if cfg!(Py_3) && has_dict {
-        let dict_slot = ffi::PyGetSetDef {
-            name: "__dict__\0".as_ptr() as *mut c_char,
-            get: Some(ffi::PyObject_GenericGetDict),
-            set: Some(ffi::PyObject_GenericSetDict),
-            doc: ptr::null_mut(),
-            closure: ptr::null_mut(),
-        };
-        props.push(dict_slot);
+        props.push(get_dict_slot());
     }
     if !props.is_empty() {
         props.push(ffi::PyGetSetDef_INIT);
@@ -424,6 +417,17 @@ where
     }
 }
 
+#[cfg(Py_3)]
+fn get_dict_slot() -> ffi::PyGetSetDef {
+    ffi::PyGetSetDef {
+        name: "__dict__\0".as_ptr() as *mut c_char,
+        get: Some(ffi::PyObject_GenericGetDict),
+        set: Some(ffi::PyObject_GenericSetDict),
+        doc: ptr::null_mut(),
+        closure: ptr::null_mut(),
+    }
+}
+
 #[cfg(Py_3)]
 fn async_methods<T>(type_info: &mut ffi::PyTypeObject) {
     if let Some(meth) = <T as class::pyasync::PyAsyncProtocolImpl>::tp_as_async() {