Enable lint: redundant_else

PyO3 · Apr 25, 2024 · e742110 · e742110
1 parent 989257c
commit e742110
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -25,6 +25,7 @@
     clippy::inefficient_to_string,
     clippy::map_unwrap_or,
     clippy::missing_const_for_fn,
+    clippy::redundant_else,
     clippy::semicolon_if_nothing_returned,
     clippy::type_repetition_in_bounds
 )]

diff --git a/src/types/tuple.rs b/src/types/tuple.rs
@@ -691,14 +691,14 @@ fn type_output() -> TypeInfo {
         fn extract_bound(obj: &Bound<'py, PyAny>) -> PyResult<Self>
         {
             let t = obj.downcast::<PyTuple>()?;
-            if t.len() == $length {
+            if t.len() != $length {
+                Err(wrong_tuple_length(t, $length))
+            } else {
                 #[cfg(any(Py_LIMITED_API, PyPy, GraalPy))]
                 return Ok(($(t.get_borrowed_item($n)?.extract::<$T>()?,)+));
 
                 #[cfg(not(any(Py_LIMITED_API, PyPy, GraalPy)))]
                 unsafe {return Ok(($(t.get_borrowed_item_unchecked($n).extract::<$T>()?,)+));}
-            } else {
-                Err(wrong_tuple_length(t, $length))
             }
         }