pystring: disable PyString::data on big-endian targets
#1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
approved these changes
Aug 26, 2021
indygreg
approved these changes
Aug 27, 2021
messense
approved these changes
Aug 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #1824, this PR disables the
PyString::dataAPI on big-endian architectures.Because of the lack of well-definedness of the underlying C bitfield, I also think it's appropriate to mark the API as
unsafe. Users are then free to use it as they please; the safety note specifies that they are responsible for confirming it works correctly on their target.If merged, I'll backport to 0.14 and release a 0.14.4.
cc @indygreg - this allows PyOxidizer to continue to use this API as needed, with explicit acknowledgement of the risks!