Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #[doc(hidden)] from trait impl items #2365

Merged
merged 1 commit into from May 10, 2022

Conversation

messense
Copy link
Member

@messense messense commented May 10, 2022

@mejrs
Copy link
Member

mejrs commented May 10, 2022

If these do actually show up in the documentation maybe we should just use a sealed trait rather than this private marker trick?

@messense
Copy link
Member Author

messense commented May 10, 2022

image

Indeed it actually show up.

@messense
Copy link
Member Author

messense commented May 10, 2022

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Changing to use sealed traits would be nice if possible!

Will merge this for now to unblock CI.

@davidhewitt davidhewitt merged commit 76c09ac into PyO3:main May 10, 2022
41 checks passed
@messense messense deleted the rm-nightly-doc-hidden branch May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants