-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add super object #2486
Add super object #2486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for working on this! I think there's a few bits which need to be tidied up, see comments below.
@davidhewitt thank you for review! I fix some comments but I have one question: #2486 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the amendments - I've given this another read and got a few final suggestions.
I think you will also need to add #[cfg(not(PyPy))]
to this file - it looks like PyPy
does not have the C APIs needed for this.
@davidhewitt thank you for review! I have done with comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, this looks great to me now!
Hello! this PR close: #2049