Allow #[new] to return existing instances
#3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
existing-instance
branch
2 times, most recently
from
9827db4
to
ace5554
Compare
adamreichold
reviewed
Jul 2, 2023
adamreichold
reviewed
Jul 2, 2023
adamreichold
reviewed
Jul 2, 2023
alex
force-pushed
the
existing-instance
branch
2 times, most recently
from
73429da
to
98709c2
Compare
davidhewitt
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
LGTM, thanks! While it's a subset of the full functionality I was thinking in #3287, it will be forwards-compatible with extending #[new] to allow any T: IntoPy<PyObject> so am happy to merge this as it unblocks users.
This was referenced Jul 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2384