fix ffi check failures for 3.12.0b4 #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
added
CI-build-full
CI-no-fail-fast
davidhewitt
force-pushed
the
3.12-ffi-check-fixes
branch
from
6492af5
to
03c34c5
Compare
|
For now I've pushed these commits also to #3335, and hopefully we will get a green CI run there even if we don't quite get one here. If that PR is green, I'd suggest merging this one first and then that one after. |
davidhewitt
force-pushed
the
3.12-ffi-check-fixes
branch
from
03c34c5
to
655de94
Compare
adamreichold
approved these changes
Jul 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to get #3335 green I hit some
ffi-checkfailures in CI. As I descended down the rabbit hole, there became enough of these that it felt appropriate to split them out into a separate PR.