Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ffi check failures for 3.12.0b4 #3342

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

davidhewitt
Copy link
Member

While trying to get #3335 green I hit some ffi-check failures in CI. As I descended down the rabbit hole, there became enough of these that it felt appropriate to split them out into a separate PR.

@davidhewitt davidhewitt added CI-build-full CI-no-fail-fast If one job fails, allow the rest to keep testing labels Jul 25, 2023
@davidhewitt
Copy link
Member Author

For now I've pushed these commits also to #3335, and hopefully we will get a green CI run there even if we don't quite get one here. If that PR is green, I'd suggest merging this one first and then that one after.

@davidhewitt davidhewitt added this pull request to the merge queue Jul 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 25, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Jul 25, 2023
Merged via the queue into PyO3:main with commit 7a2fc86 Jul 25, 2023
60 checks passed
@davidhewitt davidhewitt deleted the 3.12-ffi-check-fixes branch July 25, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-full CI-no-fail-fast If one job fails, allow the rest to keep testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants