Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PyTypeObject and PyTypeCreate #350

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Feb 12, 2019

No description provided.

kngwyu
kngwyu previously requested changes Feb 13, 2019
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kngwyu
Copy link
Member

kngwyu commented Feb 13, 2019

Looks reasonable changes for me 👍

@kngwyu kngwyu dismissed their stale review February 13, 2019 02:34

I mistakenly pushed 'requeste change' button

@konstin konstin merged commit 94cb3e7 into master Feb 13, 2019
@konstin konstin deleted the type_object_trait_cleanup branch February 13, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants