ci: allow some dead code warnings on nightly #3813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the latest nightly has got some better dead code detection for unused trait methods. While that's very welcome, the
careful
job is blocking merges due to this new warning.On the main nightly job, this is also being emitted as an error:
I'm pretty sure we'll use that
downcast_into
method soon in #3703 or similar, so I'm going to just leavenightly
broken in the very short term. I think the PR diff here should be sufficient to fixcareful
.Will proceed straight to merge to unblock CI.