Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store the FnArg ident as a Cow instead of a reference #4157

Merged
merged 1 commit into from
May 8, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented May 4, 2024

This allow also storing idents that were generated as part of the macro instead of only ones the were present in the source code. This is needed for example in complex enum tuple variants (#4072) to generate idents for (anonymous) tuple fields.

Closes #4156

This allow also storing idents that were generated
as part of the macro instead of only ones the were
present in the source code. This is needed for
example in complex enum tuple variants.
@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label May 4, 2024
@Icxolu Icxolu mentioned this pull request May 5, 2024
6 tasks
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks 👍

@davidhewitt davidhewitt added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@Icxolu
Copy link
Contributor Author

Icxolu commented May 6, 2024

I guess rust-lang/cargo#13571 broke the nightly build (and probably careful too)

@adamreichold adamreichold added this pull request to the merge queue May 8, 2024
Merged via the queue into PyO3:main with commit d803f7f May 8, 2024
44 checks passed
@Icxolu Icxolu deleted the fnarg-cow branch May 8, 2024 16:22
@newcomertv
Copy link
Contributor

Thanks for the PR.
I'll integrate that into #4072 this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace &'a Ident with Cow in FnArg Enum
4 participants