fix clippy #4227
Closed
fix clippy #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! So I think the problem here is that CI runs the The problem is that the config files also control the abi3 feature, and I recently realised in #4185 (comment) that this also creates issues with I'm not sure what the right solution is; I guess to some extent it requires adding additional complexity in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I get clippy failures on the two runs with
abi3when runningnox -s clippyonmainlocally. It looks like they originate from #3835. Looking at the feature flags, it seems correct to me that they trigger, but I'm not sure why CI (on main and PRs) does not seem to care...