Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump diagnostic_namespace rust version #4268

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

mejrs
Copy link
Member

@mejrs mejrs commented Jun 20, 2024

Now that rust 1.79 is out, I'd like to avoid using diagnostic_namespace on 1.78. Because we don't test CI for 1.78 it seems prudent to not use it for that version.

@mejrs mejrs added the CI-skip-changelog Skip checking changelog entry label Jun 20, 2024
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

I guess in general we only need to do this because of the ICE, rather than every stable release?

@mejrs
Copy link
Member Author

mejrs commented Jun 20, 2024

I guess in general we only need to do this because of the ICE, rather than every stable release?

Unless new ices or other gotchas are discovered, yes :)

@mejrs mejrs added this pull request to the merge queue Jun 20, 2024
Merged via the queue into PyO3:main with commit a983b2f Jun 20, 2024
42 checks passed
@mejrs mejrs deleted the diagnostic_attr branch June 20, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants