Custom sdist command extends from setuptools instead of distutils #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahhhh, fascinating. Thanks for debugging this! |
davidhewitt
approved these changes
Mar 11, 2021
davidhewitt
reviewed
Mar 11, 2021
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
davidhewitt
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Thanks! I'll release later when I have a moment. @messense if you want to do it sooner please feel welcome.
Publishing the github release will automatically trigger the action to upload to PyPI.
I usually push a branch with the release commit and publish the release targeting that branch, then merge the branch into master once the release is live.
inmantaci
added a commit
to inmanta/inmanta-core
that referenced
this pull request
Mar 12, 2021
Bumps [setuptools-rust](https://github.com/PyO3/setuptools-rust) from 0.12.0 to 0.12.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/PyO3/setuptools-rust/releases">setuptools-rust's releases</a>.</em></p> <blockquote> <h2>v0.12.1</h2> <h3>Fixed</h3> <ul> <li>Fix some files unexpectedly missing from <code>sdist</code> command output. <a href="https://github.com/PyO3/setuptools-rust/pull/125">#125</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PyO3/setuptools-rust/blob/master/CHANGELOG.md">setuptools-rust's changelog</a>.</em></p> <blockquote> <h2>0.12.1 (2021-03-11)</h2> <h3>Fixed</h3> <ul> <li>Fix some files unexpectedly missing from <code>sdist</code> command output. <a href="https://github.com/PyO3/setuptools-rust/pull/125">#125</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PyO3/setuptools-rust/commit/0e8eb5a33bd7f3d65c43c5af77bc15f67affb1b0"><code>0e8eb5a</code></a> release: 0.12.1</li> <li><a href="https://github.com/PyO3/setuptools-rust/commit/2313175be1b70136ee24bc52510846553d28e191"><code>2313175</code></a> Custom sdist command extends from setuptools instead of distutils (<a href="https://github.com/PyO3/setuptools-rust/issues/125">#125</a>)</li> <li><a href="https://github.com/PyO3/setuptools-rust/commit/fd4d83ea8598e64056b6c97c0e7fdb29478173c4"><code>fd4d83e</code></a> Merge pull request <a href="https://github.com/PyO3/setuptools-rust/issues/123">#123</a> from PyO3/release-0.12.0</li> <li>See full diff in <a href="https://github.com/PyO3/setuptools-rust/compare/v0.12.0...v0.12.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will fix #123 (comment)
cc @alex