Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RustBin build without wheel #273

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix RustBin build without wheel #273

merged 1 commit into from
Jul 28, 2022

Conversation

jameshilliard
Copy link
Contributor

We shouldn't depend on wheel unless building a .whl file.

Fixes: #1028

@jameshilliard jameshilliard mentioned this pull request Jul 28, 2022
Closed
messense
messense reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also add a changelog entry.

@jameshilliard
Copy link
Contributor Author

Please also add a changelog entry.

Added

@jameshilliard
Fix RustBin build without wheel
60c6511 
We shouldn't depend on wheel unless building a .whl file.
messense added a commit to PyO3/maturin that referenced this pull request Jul 28, 2022
@messense
Partially revert b6b7375
c0913ac 
It's been addressed in PyO3/setuptools-rust#273
@messense messense merged commit 5be25fe into PyO3:main Jul 28, 2022
@jameshilliard jameshilliard deleted the build-nowheel branch July 28, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd_obj = self.command_obj[command] = klass(self) TypeError: 'NoneType' object is not callable
2 participants
@jameshilliard @messense