Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor consistency check, improve performance #454

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

FabianHofmann
Copy link
Collaborator

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@p-glaum
Copy link
Contributor

p-glaum commented Sep 23, 2022

I was actually also working today on the consistency check because I encountered some infeasibilities and problems when solving my network due to nan values in the capital costs of n.generators. I started implementing a feature within check_inconsistency to check automatically before solving a network if there could be any issues which could occur because of nan values. Maybe we could also implement it in this PR or do another one. What do you think?
https://github.com/p-glaum/PyPSA/tree/update_consistency_check

@fneum
Copy link
Member

fneum commented Sep 24, 2022

@p-glaum separate Pr Based on this are would be good

@fneum fneum merged commit c6eb3a3 into master Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants