Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time-varying efficiencies and standing losses for all components #572

Merged
merged 9 commits into from Mar 31, 2023

Conversation

fneum
Copy link
Member

@fneum fneum commented Feb 22, 2023

Closes #492.

Changes proposed in this Pull Request

  • add unit test for functionality check
  • check IO for new series data

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • [ ] Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@fneum fneum requested a review from FabianHofmann March 5, 2023 15:31
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 96.29% and project coverage change: +0.92 🎉

Comparison is base (be05f3c) 75.61% compared to head (1790ecf) 76.54%.

❗ Current head 1790ecf differs from pull request most recent head 241a141. Consider uploading reports for the commit 241a141 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   75.61%   76.54%   +0.92%     
==========================================
  Files          24       24              
  Lines        6246     6258      +12     
  Branches     1336     1336              
==========================================
+ Hits         4723     4790      +67     
+ Misses       1240     1186      -54     
+ Partials      283      282       -1     
Impacted Files Coverage Δ
pypsa/pf.py 83.47% <83.33%> (+0.05%) ⬆️
pypsa/linopf.py 80.35% <100.00%> (+0.17%) ⬆️
pypsa/opf.py 89.78% <100.00%> (+0.22%) ⬆️
pypsa/optimization/constraints.py 91.68% <100.00%> (ø)
pypsa/optimization/global_constraints.py 87.15% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, can we rename test/test_lopf to something more specific? test_lopf_varying_inputs?

@fneum
Copy link
Member Author

fneum commented Mar 31, 2023

Done.

@fneum fneum merged commit 3f7b757 into master Mar 31, 2023
11 of 13 checks passed
@fneum fneum mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-dependent efficiencies / standing losses for generators, stores, storage_units
2 participants