Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit commitment for links #582

Merged
merged 7 commits into from Mar 31, 2023
Merged

add unit commitment for links #582

merged 7 commits into from Mar 31, 2023

Conversation

fneum
Copy link
Member

@fneum fneum commented Mar 17, 2023

Closes #552.

Changes proposed in this Pull Request

Implements unit commitment constraints for Link component in non-pyomo interfaces.

For native, a little generalisation of the UC variable/constraint definition was necessary

For linopy, actually no modifications are necessary except for adding the corresponding attributes to the Link component.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • [] Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 91.30% and project coverage change: -0.09 ⚠️

Comparison is base (1790ecf) 76.54% compared to head (0900d14) 76.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   76.54%   76.45%   -0.09%     
==========================================
  Files          24       24              
  Lines        6258     6257       -1     
  Branches     1336     1337       +1     
==========================================
- Hits         4790     4784       -6     
- Misses       1186     1188       +2     
- Partials      282      285       +3     
Impacted Files Coverage Δ
pypsa/optimization/optimize.py 87.79% <ø> (-0.40%) ⬇️
pypsa/linopf.py 80.20% <91.30%> (-0.16%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fneum fneum marked this pull request as ready for review March 31, 2023 09:52
@fneum fneum merged commit dfccb2e into master Mar 31, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce unit commitment for Link component
2 participants